Merge feast-snowflake plugin into main repo with documentation #2193
Conversation
|
Hi @sfc-gh-madkins. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @tsotnet |
There was a problem hiding this comment.
you'll also need to change
+ make a data source creator likeI setup secrets for this which will be in the environment variables which you can use in tests:
SNOWFLAKE_CI_USER
SNOWFLAKE_CI_PASSWORD
SNOWFLAKE_CI_DEPLOYMENT
Codecov Report
@@ Coverage Diff @@
## master #2193 +/- ##
==========================================
- Coverage 59.67% 58.70% -0.98%
==========================================
Files 108 112 +4
Lines 9111 9570 +459
==========================================
+ Hits 5437 5618 +181
- Misses 3674 3952 +278
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@adchia Can you also add secrets for SNOWFLAKE_CI_ROLE & SNOWFLAKE_CI_WAREHOUSE and make sure everything is case sensitive -- most objects created in snowflake are UPPERCASE The account/user should have a database: FEAST and schema: PUBLIC created |
|
/ok-to-test |
|
@sfc-gh-madkins as mentioned offline, added all the secrets. Let me know when this is ready for another pass (With the datasourcecreator logic all taken cared of) |
|
also you need to sign your commits |
|
To fix the tests, I think you'll need to pass the secrets to the |
|
Hi @sfc-gh-madkins, please rebase and run |
sdk/python/tests/integration/feature_repos/universal/data_sources/snowflake.py
Outdated
Show resolved
Hide resolved
Signed-off-by: david <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
… gone (#2240) * Delete entity from redis when the last attached feature view is deleted Signed-off-by: pyalex <[email protected]> * Delete entity key from Redis only when all attached feature views are gone Signed-off-by: pyalex <[email protected]> * make lint happy Signed-off-by: pyalex <[email protected]> * make lint happy Signed-off-by: pyalex <[email protected]> * one more try with mypy Signed-off-by: pyalex <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Michelle Rascati <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Judah Rand <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
…ra (#2258) * add snowflake environment vars to test framework Signed-off-by: sfc-gh-madkins <[email protected]> * add snowflake environment vars to test framework Signed-off-by: sfc-gh-madkins <[email protected]>
* Refactor `UNIX_TIMESTAMP` conversion Signed-off-by: Judah Rand <[email protected]> * Return `UNIX_TIMESTAMP` types as `datetime` to user Signed-off-by: Judah Rand <[email protected]> * Fix linting errors Signed-off-by: Judah Rand <[email protected]> * Rename variable to something more sensible Signed-off-by: Judah Rand <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
* Run validation and inference on views and entities during plan Signed-off-by: Felix Wang <[email protected]> * Do not log objects that are unchanged Signed-off-by: Felix Wang <[email protected]> * Rename Fco to FeastObject Signed-off-by: Felix Wang <[email protected]> * Remove useless method Signed-off-by: Felix Wang <[email protected]> * Lint Signed-off-by: Felix Wang <[email protected]> * Always initialize registry during feature store initialization Signed-off-by: Felix Wang <[email protected]> * Fix usage test Signed-off-by: Felix Wang <[email protected]> * Remove print statements Signed-off-by: Felix Wang <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
…y with Java Feast Server (#2259) Signed-off-by: NalinGHub <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: sfc-gh-madkins <[email protected]>
Signed-off-by: sfc-gh-madkins <[email protected]>
|
btw @adchia @sfc-gh-madkins the test currently failing is (I think) unrelated to this PR: I've seen this failure in a bunch of other PRs as well (see e.g. some of the integration tests running on master here; I'm not sure yet if Dynamo is just super flaky or if the test is broken - I just tried running this test locally and it also failed with the same error the test was introduced by @pyalex in #2240, so maybe he might know what's going on |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, sfc-gh-madkins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Allows feast to use Snowflake as an Offline & Online Store
Which issue(s) this PR fixes:
Fixes # NONE
Does this PR introduce a user-facing change?: